Fix some chisel3 compatibility problems

aswaterman commented 7 years ago

These compatibility issues aren't news, but it looks like a few of the old ones have snuck back in recently:

You can't assign from UInt to SInt, or vice versa, without an explicit cast. asUInt and asSInt are the type-punning operations. You can also use zext to convert from a UInt/Bool to an SInt with the same numerical value (i.e., it concatenates a 0 sign bit and converts the type to SInt).
Local wires need to be declared with Wire, not just the type, e.g., Wire(Vec(n, Bool())) makes a Wire that consists of an n-entry Vec of Bools.

edcote commented 7 years ago

Thanks Andrew, this resolved the issue that I was facing.

You may also consider updating libraryDepdencies in build.sbt to point to chisel3, instead of chisel.

jhauser-ucberkeley commented 7 years ago

I believe the edits necessary to satisfy this request have now been committed. I did not accept the pull request verbatim because I wanted to do a few things differently. Please confirm that the latest committed version takes care of this issue for you.

aswaterman commented 7 years ago

@jhauser-ucberkeley So confirmed. Thank you.

ucb-bar / berkeley-hardfloat

Fix some chisel3 compatibility problems #16