search

ucb-bar / berkeley-hardfloat

Other
291 stars 87 forks source link

Bump scalaVersion to match rocket-chip. #22

Closed richardxia closed 6 years ago

richardxia commented 6 years ago

@yunsup @aswaterman @palmer-dabbelt I don't have commit access to this repo, so one of you will need to merge this in.

I'm bumping the Scala version to 2.11.12 to match the current version of rocket-chip. The reason I'm bumping it is because otherwise, sbt will redundantly compile certain dependencies for each individual version of Scala referenced by all sub projects (and sub sub projects).

palmer-dabbelt commented 6 years ago

Have you run the tests and cleared this with @jhauser-ucberkeley?

richardxia commented 6 years ago

Thanks for pointing out the unit tests. I just ran them and it looks like they're still passing. I have not spoken to @jhauser-ucberkeley yet, so thanks for pulling him into the thread. I'm hoping this change is straightforward and uncontroversial.