Support Mill 0.11 - Githubissues

ucb-bar / berkeley-hardfloat

Other

287 stars 87 forks source link

Support Mill 0.11 #78

Closed sequencer closed 1 year ago

sequencer commented 1 year ago

This PR support hardfloat for mill 0.11 which is incompatible to previous version. In the later PR, I'll make hardfloat be able to cross compile aginst Chisel 3.6 and Chisel 5 to ease the version bumping effort.

sequencer commented 1 year ago

The reason not maintaining the sbt script is it cannot support cross chisel building flow.

jerryz123 commented 1 year ago

The reason not maintaining the sbt script is it cannot support cross chisel building flow.

Does that feature need to be in the SBT?

sequencer commented 1 year ago

Does that feature need to be in the SBT?

It doesn't, but I think if not releasing and testing via SBT, I didn't see the reason to keep them.

jerryz123 commented 1 year ago

Does that feature need to be in the SBT?

It doesn't, but I think if not releasing and testing via SBT, I didn't see the reason to keep them.

The tests currently use SBT. I don't think we should remove things until they break, or conflict with new features.

sequencer commented 1 year ago

The tests currently use SBT. I don't think we should remove things until they break, or conflict with new features.

I'm working on experimentally migrating to probe API from Chisel 5, here is my idea:

Like what I did in RC, firstly migrate all test logic to build system.(verilating, linking, run test...)
Make tests only contain the Chisel Module and firrtl elaboration logic.
writing TB with chisel probe API to probe signals and call C-DPI to integrate with testfloat.

This makes hardfloat being able to be eventually tests with commercial tools(vcs, ncsim), rather than verilator only tests.

jerryz123 commented 1 year ago

I'm working on experimentally migrating to probe API from Chisel 5, here is my idea:

Like what I did in RC, firstly migrate all test logic to build system.(verilating, linking, run test...)

Make tests only contain the Chisel Module and firrtl elaboration logic.

writing TB with chisel probe API to probe signals and call C-DPI to integrate with testfloat.

This makes hardfloat being able to be eventually tests with commercial tools(vcs, ncsim), rather than verilator only tests.

I think this is a very good idea. Until we have those tests online, we should keep the SBT tests running.

sequencer commented 1 year ago

0ab3c9f should pass test now which supports crossing 3 chisel versions.