Closed ucbjrl closed 5 years ago
We may want to hold off on committing these changes to release
until we publish a 3.1.x version that supports asBool
.
They should be fine for master
That's an excellent point. Let me try to address it.
Would it be better to address this by adding a copy
method to TesterOptionsManager
? Then we could copy it once the arguments have been parsed (instead of repeatedly parsing the arguments).
I'd say that would have been worth doing if we were sticking to OptionsManagers but given Stage/Phases I would say "no, it's not worth it". I'd just write a utility copy method of your own like
object OptionsCopy {
def apply(t: TesterOptionsManager): TesterOptionsManager = {
new TesterOptionsManager {
testerOptions = t.testerOptions.copy()
interpreterOptions = t.interpreterOptions.copy()
chiselOptions = t.chiselOptions.copy()
firrtlOptions = t.firrtlOptions.copy()
treadleOptions = t.treadleOptions.copy()
}
}
}
Replace
toBool
withasBool
. Ensure each test run uses a freshTesterOptionsManager
so we don't end up with: