search

ucb-bar / chisel2-deprecated

chisel.eecs.berkeley.edu
387 stars 90 forks source link

Chisel SystemC update #560

Open capetry opened 8 years ago

capetry commented 8 years ago

We have been working recently on Chisel SystemC backend to support all signals and ports like Decoupled and Valid, also we improved the automatic generation of the SystemC wrappers. Now, we are submitting this request to be evaluated and integrated into Chisel, if approved.

ucbjrl commented 8 years ago

This is great. I've squashed your commits and merged them into a new Chisel branch: systemcupdatepr560

One of our tests failed (SystemCSuite.testTopLevelIO) since we no longer get failures for top-level IOs that aren't decoupled. I've changed the expected test results so this no longer expects failures and now passes. Can you verify that this is the expected behaviour?

Please add some tests of this new functionality. Push any new changes to this branch ( https://github.com/ucb-bar/chisel/tree/systemcupdatepr560).

ghost commented 8 years ago

Can one of the admins verify this patch?

ucbjrl commented 8 years ago

ok to test