ucb-bar / chisel2-deprecated

chisel.eecs.berkeley.edu
388 stars 90 forks source link

Issue deprecation warning on startup. #749

Closed ucbjrl closed 6 years ago

ducky64 commented 6 years ago

Does it make sense to print the error at the end of elaboration? Printing it at the start could just mean that it immediately gets pushed off the screen by a wall of text generated during elaboration?

ucbjrl commented 6 years ago

If you have access to the millennium machines, you can check the console output from bare-chisel build 512.

ducky64 commented 6 years ago

Yeah that definitely looks good.

Appears to both print at the end of elaborate

CppBackend: createCppFile BitPatSuite_BitPatBoolModule_1.cpp
[info] [0.521] g++ -c -o test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.o  -I../ -I/csrc/  test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.cpp RET 0
[info] [0.912] g++ -c -o test-outputs/BitPatSuite_BitPatBoolModule_1.o  -I../ -I/csrc/  test-outputs/BitPatSuite_BitPatBoolModule_1.cpp RET 0
[info] [0.978] g++   -o test-outputs/BitPatSuite_BitPatBoolModule_1 test-outputs/BitPatSuite_BitPatBoolModule_1.o test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.o RET 0
[warn]: Chisel2 is deprecated. Please use Chisel3: https://github.com/freechipsproject/chisel3

and test

STEP 1 -> 7
  EXPECT BitPatSuite_BitPatModule_1.io_out -> 0x0 == 0x0 PASS
  POKE BitPatSuite_BitPatModule_1.io_in <- 0x7
STEP 1 -> 8
  EXPECT BitPatSuite_BitPatModule_1.io_out -> 0x1 == 0x1 PASS
RAN 8 CYCLES PASSED
[warn]: Chisel2 is deprecated. Please use Chisel3: https://github.com/freechipsproject/chisel3
ucbjrl commented 6 years ago

Right. We could easily suppress the printing at the end of the test run, but the argument you raised earlier (the warning may scroll off the screen given sufficient output) would apply here as well. Suppressing the warning after elaboration iff we know testing will follow seemed an unwarranted complication: since we want to discourage usage, erring on the side of too many warnings seems quite appropriate.

On Tue, Apr 17, 2018 at 1:43 PM, Richard Lin notifications@github.com wrote:

Yeah that definitely looks good.

Appears to both print at the end of elaborate

CppBackend: createCppFile BitPatSuite_BitPatBoolModule_1.cpp [�[35minfo�[0m] [0.521] g++ -c -o test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.o -I../ -I/csrc/ test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.cpp RET 0 [�[35minfo�[0m] [0.912] g++ -c -o test-outputs/BitPatSuite_BitPatBoolModule_1.o -I../ -I/csrc/ test-outputs/BitPatSuite_BitPatBoolModule_1.cpp RET 0 [�[35minfo�[0m] [0.978] g++ -o test-outputs/BitPatSuite_BitPatBoolModule_1 test-outputs/BitPatSuite_BitPatBoolModule_1.o test-outputs/BitPatSuite_BitPatBoolModule_1-emulator.o RET 0 [�[33mwarn�[0m]: Chisel2 is deprecated. Please use Chisel3: https://github.com/freechipsproject/chisel3

and test

STEP 1 -> 7 EXPECT BitPatSuite_BitPatModule_1.io_out -> 0x0 == 0x0 PASS POKE BitPatSuite_BitPatModule_1.io_in <- 0x7 STEP 1 -> 8 EXPECT BitPatSuite_BitPatModule_1.io_out -> 0x1 == 0x1 PASS RAN 8 CYCLES PASSED [�[33mwarn�[0m]: Chisel2 is deprecated. Please use Chisel3: https://github.com/freechipsproject/chisel3

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ucb-bar/chisel/pull/749#issuecomment-382136552, or mute the thread https://github.com/notifications/unsubscribe-auth/AGh1wCbjeHqFaNHwHQEg95Mb_BKx9HwAks5tplPXgaJpZM4TXPHi .

ducky64 commented 6 years ago

I don't think suppression is a good idea, I posted the two examples there for those who do not have access to the build outputs.

ucbjrl commented 6 years ago

We're in violent agreement.