ucb-bar / dsptools

A Library of Chisel3 Tools for Digital Signal Processing
Apache License 2.0
227 stars 38 forks source link

Fix multiple issues for 3.5.0-RC2 Release #241

Closed jackkoenig closed 2 years ago

jackkoenig commented 2 years ago

This ballooned into several fixes in order to get CI passing:

In the case of DspReal, this is unfortunately a source incompatible change. It's not clear if it's possible to do this in a way that would be backwards compatible. The previous code was including a literal in the elements of the DspReal Bundle and this is something that was never really intended in Chisel3. It violates many internal assumptions and often would result in errors. The checking for this case now happens earlier and thus the code had to change.

Needed for 3.5.0-RC2