Pydantic bump, fix readthedocs w/ Poetry 1.8 - Githubissues

ucb-bar / hammer

Hammer: Highly Agile Masks Made Effortlessly from RTL

BSD 3-Clause "New" or "Revised" License

255 stars 59 forks source link

Pydantic bump, fix readthedocs w/ Poetry 1.8 #847

Closed harrisonliew closed 8 months ago

harrisonliew commented 8 months ago

Poetry 1.8 broke readthedocs - implemented the temporary fix.
Also bumped to pydantic v2 (with requisite migration).
Added tests/ to mypy type checking.
Dev documentation updates.

Related PRs / Issues

Type of change:

[X] Bug fix
[ ] New feature
[X] Other enhancement

Impact:

[ ] Change to core Hammer
[ ] Change to a Hammer plugin
[X] Other

Contributor Checklist:

[X] Did you set master as the base branch?
[X] Did you state the type-of-change/impact?
[X] Did you delete any extraneous prints/debugging code?
[X] (If applicable) Did you add documentation for the feature?
[X] (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
[ ] (If applicable) Did you add a unit test demonstrating the PR?
[ ] (If applicable) Did you run this through the e2e integration tests?
[ ] (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

vighneshiyer commented 8 months ago

Thanks! There are a few pydantic APIs to update in tests which the bump-pydantic script doesn't seem to touch, not sure why that's not working, but we can fix these by hand.

Also, now may be a good time to add mypy -p tests to workflows/pr.yml. There have been failing typechecks for tests that we can patch in this PR too.