Method for renewing Instructional Computing Allowances (ICAs) - Githubissues

ucb-rit / coldfront

HPC Resource Allocation System

https://coldfront.readthedocs.io

GNU General Public License v3.0

3 stars 3 forks source link

Method for renewing Instructional Computing Allowances (ICAs) #623

Closed adeng27 closed 4 months ago

adeng27 commented 5 months ago

Based off code from @matthew-li

This PR contains updated projects command-line tool (coldfront.core.project.management.commands.projects) to enable renewal of ICA projects that have the "Inactive" status.
- Added a subcommand renew by which this can be done.
  - It takes arguments: the name of the Project, the username of the User making the request, and the name of the AllocationPeriod the allowance will be valid for.
  - It will approve and process the request. I will provide you with some example code I've run manually in the past that should be adapted into this command.
  - Disallow renewals of other project types at this point (so only ICAs).
  - There should be a dry_run flag (see the create subcommand).

adeng27 commented 4 months ago

Assumptions made:

The ICA Project must have only 1 PI.
I assumed that the pre-project and post-project referred to the same project (namely, the inputed project).
The requester must be a part of the project or else a CommandError will be raised.
The allocation period must be currently ocurring or else a CommandError will be raised.
The project name inputed must start with 'ic_' or a CommandError will be raised.

adeng27 commented 4 months ago

Changes made:

Projects no longer need to have just 1 PI. Before an error would occur if there were more than 1, but that has been adjusted. This was achieved by adding an additional argument which is the PI's username.
Writes to the database were put in a transaction
Limited acceptable AllowancePeriods to those for ICA projects