search

ucbds-infra / otter-grader

A Python and R autograding solution
https://otter-grader.readthedocs.io
BSD 3-Clause "New" or "Revised" License
126 stars 66 forks source link

Dockerfile is different in 5.7.0 and no longer works #849

Closed nibheis closed 1 month ago

nibheis commented 1 month ago

Describe the bug From 5.6.0 to 5.7.0, the Dockerfile got changed and now building the image fails. New lines in Dockerfile:

ENV PATH=/root/miniforge3/bin:$PATH
ADD __otter-grader /tmp/otter-grader
RUN mamba run -n otter-env pip install /tmp/otter-grader
RUN rm -rf /tmp/*

The build fails on the ADD __otter-grade /tmp/otter-grader line.

To Reproduce Steps to reproduce the behavior:

  1. run otter grade on docker, on a remote docker host (via ssh).

Maybe the ADD __... line works on a local docker host? TBH, I don't know what is the purpose of the double underscore - I did not find any information in the docker documentation.

Expected behavior Image building and grading from otter grade work as expected.

Versions Only happens with 5.7.0.

Additional context If I comment out those 4 lines in the Dockerfile (i.e. reverting to the Dockerfile from 5.6.0), then the docker image builds correctly and grading occures correctly too.

chrispyles commented 1 month ago

The “new” contents are actually used for testing the docker image, looks like I accidentally committed the changes. I’ll remove them and release v5.7.1 tonight.

nibheis commented 1 month ago

Thank you very much for your quick action ; it was my understanding that those lines were for your debugging :-)

chrispyles commented 1 month ago

v5.7.1 is now up