search

ucberkeley / moocchat

SaaS app for integrating peer learning/peer discussion into MOOCs and similar settings
GNU General Public License v3.0
8 stars 4 forks source link

using foreman #12

Open luckyx1 opened 10 years ago

luckyx1 commented 10 years ago

Is it intended that we install the gem locally, or can we add the gem to the Gemfile? also in the moocchat / app / middleware /chat_backend.rb there is a lot of put that is being seen in the terminal, can we remove (unless this is intentional) and/or comment them out to follow Armando's email of removing debugger code.

armandofox commented 10 years ago

Is it intended that we install the gem locally, or can we add the gem to the Gemfile?

You always add the gem to the Gemfile. always. then let Bundler install it locally as needed. that way the Gemfile.lock gets the right version.

also in the moocchat / app / middleware /chat_backend.rb there is a lot of put that is being seen in the terminal, can we remove (unless this is intentional) and/or comment them out to follow Armando's email of removing debugger code.

yes please. can whoever owns that code clean it up? two rules we need to follow are:

  • never push code with red (failing) tests to origin/master
  • never push debugging/commented-out code to origin/master — Reply to this email directly or view it on GitHub.