search

uccross / skyhookdm-arrow

Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.
https://arrow.apache.org
Apache License 2.0
10 stars 7 forks source link

[Test] scripts/test.sh may not put the libcls_arrow library to correct location #222

Closed ljishen closed 3 years ago

ljishen commented 3 years ago

When following the contribution guide, the CentOS environment in uccross/skyhookdm-arrow:v0.2.0 has the default class lookup dir set to @CMAKE_INSTALL_LIBDIR@/rados-classes, which is /usr/lib64/rados-classes. This is not the path /usr/lib/x86_64-linux-gnu/rados-classes/ the test.sh script supposes.

To make it portable, we can set the osd class dir for [osd] in the ceph.conf. This is the same way used by vstart.sh in Ceph.

ljishen commented 3 years ago

@JayjeetAtGithub Would you tell me what is the purpose of step 3 "Install docker" in the contribution guide?

JayjeetAtGithub commented 3 years ago

@ljishen That looks like a very bad mistake. It should be step 2 or maybe we can omit it. Thanks for reporting.

ljishen commented 3 years ago

@JayjeetAtGithub I see. Thanks for your response.

JayjeetAtGithub commented 3 years ago

@YashJipkate Can you please fix the above problem ?

YashJipkate commented 3 years ago

I'll omit the point altogether then, just add a link to the docker page.