Cleaned up some error handling.

uccross / skyhookdm-arrow

Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.

https://arrow.apache.org

Apache License 2.0

10 stars 7 forks source link

Cleaned up some error handling. #272

Closed westonpace closed 3 years ago

westonpace commented 3 years ago

Try and avoid ValueOrDie at all costs because that will assert and crash the program instead of propagating the error. This PR should replace most (all?) instances of ValueOrDie with ARROW_ASSIGN_OR_RAISE which is the preferred method of handling errors. In a few spots ARROW_ASSIGN_OR_RAISE was not appropriate (since the return value of the function was not Status/Result) and so I manually inspected the status, reported the error, and bailed out gracefully.

github-actions[bot] commented 3 years ago

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

MINOR: [${COMPONENT}] ${SUMMARY}