search

uccross / skyhookdm-ceph-cls

Skyhook Data Management: Storage and management of tabular data in Ceph.
https://www.skyhookdm.com
GNU Lesser General Public License v2.1
13 stars 9 forks source link

Replace deprecated Arrow functions #41

Closed aditigupta17 closed 4 years ago

aditigupta17 commented 4 years ago

This PR fixes the build warnings caused due to deprecated Arrow functions in v.0.17.0 by re-implementing them as per new function signatures.

ivotron commented 4 years ago

thanks @aditigupta17, Travis prevents variables from being used in forks. So in this case, the push-img step is making use of DOCKER_USERNAME and DOCKER_PASSWORD. Can you define them in travis for your fork (see here for instructions)? It actually doesn't matter what their values are as this step is skipped for branches other than luminous/master

ivotron commented 4 years ago

one thing I forgot to point out is that once you define the secrets on the travis config for your fork, the tests on the PR will still be shown as failed, but they should pass on the tests associated to your branch, which will be shown here: https://travis-ci.org/github/aditigupta17/skyhookdm-ceph-cls/branches . So you should see the tests passing there.

aditigupta17 commented 4 years ago

Thanks @ivotron, after defining the secrets, build and tests pass for my fork (except for push-img): https://travis-ci.org/github/aditigupta17/skyhookdm-ceph-cls

ivotron commented 4 years ago

awesome, that means we're good. Sorry for the inconvenience, I know that's kind of an annoying contributor experience but unfortunately that's an outcome of Travis' security measures (see here for more on how other projects deal with this).

We will address it in popper via https://github.com/getpopper/popper/issues/851. But until this feature in popper is implemented/merged, we'll have to do it this way (tests will fail on this PR, and they should pass on your end on the travis project of your fork).

I left a couple of questions. Also, I think we also need to port this to nautilus (master branch), could you please open a PR against the master branch?

aditigupta17 commented 4 years ago

Thanks a lot @ivotron, it's completely alright. Sure, I will send a PR against the master branch.

aditigupta17 commented 4 years ago

Sent against master here: #43