Closed kingwind94 closed 2 years ago
Hi @jlefevre , I can help with the CLS. I have a few refactorings to be done. I am thinking If I can create a new branch from this branch and work there. I can work there and maybe you can help with some review. Does that sound good ?
Sure, let me merge that branch into this one and we can continue working from here.
Sure, let me merge that branch into this one and we can continue working from here.
Hi Jayjeet, I didn't get to this yet but will get to it tomorrow. Thanks for all the work on this branch. I reviewed some of it, and will need to have a call with you for some quick questions before merging. So how about 8a or 10a Wednesday? Else maybe 9a Tuesday (tomorrow will work as well). Jeff
On Sat, Oct 10, 2020 at 11:32 AM Jayjeet Chakraborty < notifications@github.com> wrote:
Sure, let me merge that branch into this one and we can continue working from here.
76 https://github.com/uccross/skyhookdm-ceph-cls/pull/76
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uccross/skyhookdm-ceph-cls/pull/75#issuecomment-706592339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADT6DLY6BMPUI3DI32MXRTSKCSCLANCNFSM4SCHA4EA .
Hi Jayjeet, I didn't get to this yet but will get to it tomorrow. Thanks for all the work on this branch. I reviewed some of it, and will need to have a call with you for some quick questions before merging. So how about 8a or 10a Wednesday? Else maybe 9a Tuesday (tomorrow will work as well). Jeff
Hi @jlefevre , Thanks for taking a look. 9AM Tuesday or 10 AM Wednesday should be good.
The functions to serialize expressions, schemas, and table to buffer list and back are defined here.
The format followed for moving Expression and Schema is
The format followed for moving Table,