search

ucd-cws / PISCES

Software for tracking and analyzing fish species range data
Other
0 stars 2 forks source link

map name inconsistencies #146

Open nickrsan opened 9 years ago

nickrsan commented 9 years ago

Original report by AndyB (Bitbucket: AndyB, GitHub: AndyB).

The default names for the maps have a couple of inconsistencies between different map sets.

  1. The main range map name ends with current version number while range unlimited and inset have number that corresponds to map queries ID

  2. The names used in main range outputs does not respect the setting in config.py (mapping.output_common_name = True and the file name includes scientific name). Unlimited and Inset maps with same setting have correct names.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Hey Andy,

I brought the Unlimited Range Maps naming convention in line with this (in c8675ca5858c7cfbc02bbf2a0f5f882bdca1cd87), but haven't done the Inset version - is that one you use?

For the config setting, I put a comment after it noting that it only affects names that aren't explicitly assigned in the database (like Main Range Maps' names, etc). Will you take a look and tell me if you think this is acceptable? Thanks

nickrsan commented 9 years ago

Original comment by AndyB (Bitbucket: AndyB, GitHub: AndyB).

I think as long as naming is consistent it works. I'm still a little confused about the names for Main Range Maps. Does changing mapping.output_common_name alter the outputs? I have it set to "True" and I'm still getting Main range maps with scientific names. Where is in the database is the name explicit assigned?