search

ucd-cws / PISCES

Software for tracking and analyzing fish species range data
Other
0 stars 2 forks source link

generate maps tool sluggish #166

Closed nickrsan closed 9 years ago

nickrsan commented 9 years ago

Original report by AndyB (Bitbucket: AndyB, GitHub: AndyB).

There is now a slight delay when using the check box options in the generate maps tool. It is about a two second pause which is causing the entire tool to feel sluggish and unresponsive.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

My guess is that his happened along with the code to make it show the selection list for each item. Maybe it's running a db query each time parameters are updated?

Marking as blocker for 2.0

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Slow in a new map document, but removing the update parameters code didn't resolve the issue.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Performance is fine in ee1311824b134bf08d3d03d5d42978652c054df4 and ead0f039cfaefda2724c5f42101bf6cfbd03acc2

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

OK in 8291cd836ee0862b752be1fdc82649250f336c05 (958) and 8bb7da898fe7516b3628b95515c2e377d070797b (965).

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Broken in (48c8c98abbf4ee6fdd8ba93d53b98fe981aa7485) 981 - must have to do with the PISCES loading behavior

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Confirmed. Only line of difference between two versions is local_vars.start() - but in the tool initialization. Maybe it needs to be moved.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Resolved in 05b48a7d5fc7b65a0a18036590f2ffedc956209a