search

ucd-cws / PISCES

Software for tracking and analyzing fish species range data
Other
0 stars 2 forks source link

Export web layers (kml/shp) only work with main range maps #86

Open nickrsan opened 9 years ago

nickrsan commented 9 years ago

Original report by AndyB (Bitbucket: AndyB, GitHub: AndyB).

The option to export KML or SHP for each layer using the generate map tool interface only work with the Main Range Maps. Selecting the options with other map sets (I tried Unlimited and Inset) produced a warning that the output names for the files are not in the python dict which is referencing the ID of the layer query.

Note sure why users would want to export the shps/kml for unlimited maps but if it only works for a select few map sets then it should be documented.

2014-10-20 10_24_26-Generate Map.png

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Thanks Andy - I have had a note in the code that this would be totally broken for other map sets, but would have probably missed it for these deliverables. That'll be pretty important. Thanks!

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Marking as critical. At the very least we need to add a better error message to the code so that it doesn't look like a crash. Something indicating it's not supported rather than that it's broken

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Issue #165 was marked as a duplicate of this issue.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

This has a temporary fix for now, where it fails gracefully in trying to write the CSV file since that's less critical. Bumping actual fix to Future.

The main work remaining is that we need to write an unknown header for the CSV file. We probably need to iterate through all the maps before exporting any CSVs to figure out what all the potential fields are.

It might also be worth just re-engineering that export section, moving the layer exports to methods on the map_layer class and thinking again through the actual workflow.

nickrsan commented 9 years ago

Original comment by Nicholas Santos (Bitbucket: nickrsan, GitHub: nickrsan).

Bumping since critical part is fixed