ucd-library / aggie-experts

Publicly reported feedback and issues for Aggie Experts
https://ucd-library.github.io/aggie-experts/
MIT License
1 stars 2 forks source link

add browse by a-z with new /api/browse routes #220, grants pagination… #257

Closed UcDust closed 7 months ago

UcDust commented 7 months ago

… #169

UcDust commented 7 months ago

This addresses the following items:

-browse by with new api -browse by to load available letters, and disable in the ui if no results for a letter -grants/citations, visibility and reject. Can’t reject grants. remove reject button -browse by, get pagination working -fix grants pagination list page -fix grants pagination edit page -is-visible for grants and citations on expert page, throw error in console if not true

Vensberg commented 7 months ago

Definition of Done for Experts A-Z browse

Vensberg commented 7 months ago

@UcDust , for Experts Browse A-Z, when I click on M, then go to page 2, then click on N (or another letter), I land on page 2 for N. Each letter should start on the equivalent of its page 1.

UcDust commented 7 months ago

@Vensberg good catch! I'll have this patched in a bit.

UcDust commented 7 months ago

@Vensberg that fix should be live on sandbox now.

Vensberg commented 7 months ago

@UcDust, Expert pagination looks good.

There is a smaller similar issue with grants pagination. If I click on page 2 of grants, then click on "return to profile" then click back on grants, page 2 opens up. This happens even if I navigate to multiple pages in between returning to "see all grants".

UcDust commented 7 months ago

@Vensberg I'll get that into the next deployment and let you know.