Grant visibility testing - Githubissues

ucd-library / aggie-experts

Publicly reported feedback and issues for Aggie Experts

https://ucd-library.github.io/aggie-experts/

MIT License

1 stars 2 forks source link

Grant visibility testing #336

Closed UcDust closed 5 months ago

UcDust commented 8 months ago

Tests for hiding/showing grants.

Test for scenario when Aggie Experts cannot connect to Elements to change the visibility of a grant.

UcDust commented 8 months ago

The API code essentially updates grant visibility in these stages:

Updates the visibility in elasticsearch
Updates the visibility in fcrepo
Updates the visibility in cdl

For development, we'll need to make sure a 500 error in step 1 doesn't change the visibility in the ui (this might be hard to replicate on test, but we can replicate locally, or deploy an update to sandbox with some intentionally failing code). A 500 error for step 2 and 3 should still update visibility in the ui for what elasticsearch has been updated to.

Vensberg commented 8 months ago

@UcDust , On changing the visibility of a grant, I see the message

Error: Update Failed

Changes to the visibility of (Travel Support for Participants in the 2015 New Security Paradigms Workshop) could not be done through Aggie Experts right now. Please, try again later, or make changes directly in the UC Publication Management System.

For more help, see troubleshooting tips.

[x] The error message appears--good
[x] UC Publication Management System redirects to Elements QA claimed grants as per requirement --good
[ ] Even though the FAQ redirects to what should be a bookmarked answer, the page opens at the very top of FAQ. Can the "How do I change the visibility of a publication or a grant?" be opened as the user lands on that page?
[ ] @Vensberg , re-check this when test is updated: When I click OK, the page looks fine, but when I refresh, the visibility icon is crossed out. We need to discuss tomorrow at sprint what should happen there--we had discussed the option of "hide from the interface now, we'll propagate to Elements later"

Vensberg commented 8 months ago

Still need to test visibility when connecting to Elements

UcDust commented 8 months ago

@Vensberg this should be ready to test once the code has been deployed.

Vensberg commented 8 months ago

I checked one of John Madigan's grants. On the second try it worked as expected, with a time wheel while the visibility changed. The relationship on QA also changed as expected. The grants are hidden from search as well. The number of hidden grants is correctly reflected as well. Looks great!

Vensberg commented 8 months ago

[ ] Keeping hte issue open to retest on test

Vensberg commented 8 months ago

The timing out happens a bit too fast.

UcDust commented 8 months ago

@Vensberg can you explain what you mean about the timing out issue?

Vensberg commented 5 months ago

Works in production.