Closed UcDust closed 2 months ago
This will include updates for the following:
@UcDust , I'd like to rework the Hide Expert message content. Can you make it: Expert will be hidden from Aggie Experts. In the Publication Management System their privacy will be set to internal. To show the expert again in Aggie Experts, you change the privacy in the Publication Management System to public or contact an Aggie Experts administrator. Are you sure you would like to continue?
@UcDust reversing from invisible to visible throws an error. Can you make that waiting period longer? It worked well for the invisible. I will hold on testing deletion, but their wait periods should probably be adjusted, too.
Now the invisible-->visible works
Based on https://github.com/ucd-library/aggie-experts/pull/358, the message for visible-->invisible should be: The expert will be hidden from Aggie Experts, but this change will not appear in Elements. This is a safeguard available only to admins, in case "Delete Expert" does not work because Elements is not reachable. It is the admin's responsibility to manually change visibility in Elements.
Based on that, the connection between the visible icon and Elements should be removed.
For deletions, the message should be: The expert will be removed from Aggie Experts. In the UC Publication Management System their privacy will be set to internal.To show the expert again in Aggie Experts, you would need to update the privacy setting to public in the UC Publication Management System. Are you sure you would like to continue?
@Vensberg this should be deployed to test for tomorrow.
@Vensberg @UcDust , Not sure why Dusty marked here, this PR had been deployed. I did deploy #373, #374 however
… no data when editing