search

ucd-library / aggie-experts

Publicly reported feedback and issues for Aggie Experts
https://ucd-library.github.io/aggie-experts/
MIT License
1 stars 2 forks source link

Pager component should always show the last page using ellipses #396

Closed UcDust closed 1 month ago

UcDust commented 2 months ago

Pager appears to not be implemented correctly – pager should always show the last page using the ellipses attribute when max page count exceeds visible count so that people understand how deep the content goes and can quickly access that content. Example: Junyi Qi shows 7 pages of works on load, but once you start clicking there are actually 11 pages of content. Pager Component: https://brand.library.ucdavis.edu/#ucd-theme-pagination

Should show 1 2 3 4 5 6 … 11

UcDust commented 2 months ago

@Vensberg this should be ready for review on test.

Vensberg commented 2 months ago

@UcDust , when I click on the ellipses, the page numbers disappear. There are only left and right arrows. I am still on the original page. The arrows reload the same page. It's probably a good idea to let the rest of the team know--the library website gives a 404 when you click on the ellipses.

I don't see guidance on what the ellipse is supposed to do. In GeeksforGeeks it moves the user half-way across the pages.

UcDust commented 2 months ago

This should be patched in this PR