search

ucd-library / dams

The UC Davis DAMS built on top of FIN
MIT License
0 stars 0 forks source link

[UX/UI] Item ark/doi links should update the scroll position to the top of the page #253

Open UcDust opened 1 week ago

UcDust commented 1 week ago

Describe the bug Currently the ark/doi links are relative links and nothing visually changes on the page when they're clicked. They should update the scroll position to be the top of the item page.

UcDust commented 1 week ago

@EricNebeker This came up during our testing, currently these links don't really indicate what's happening, so we're going to update the scroll position so things go back to the top of the page. But for the links to an actual image file or media file, do you want them to open that file directly? Or is it ok to just stay on the same item landing page?

EricNebeker commented 1 week ago

I’m not sure I understand the question.

Eric Nebeker Digital Asset Specialist Archives & Special Collections UC Davis Library

On Nov 18, 2024, at 4:29 PM, Dusty Cartwright @.***> wrote:



@EricNebekerhttps://github.com/EricNebeker This came up during our testing, currently these links don't really indicate what's happening, so we're going to update the scroll position so things go back to the top of the page. But for the links to an actual image file or media file, do you want them to open that file directly? Or is it ok to just stay on the same item landing page?

— Reply to this email directly, view it on GitHubhttps://github.com/ucd-library/dams/issues/253#issuecomment-2484456832, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIL4DMB4FVXQKDVPGAYI3FL2BKA7VAVCNFSM6AAAAABSA32BZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUGQ2TMOBTGI. You are receiving this because you were mentioned.Message ID: @.***>

UcDust commented 1 week ago

@EricNebeker mostly we're just not sure if that link with a filename/extension should do something other than just update the url to the page. Like most links with file names you would anticipate it would trigger a file download or something, but since we have a separate download section of the page perhaps that's not a good move here. We can chat about it tomorrow though.

UcDust commented 3 days ago

@wrenaria this should be ready to test on dev.