Map panel: Connections are showing incorrectly

[wrenaria]

Connections are showing incorrectly and need to be fixed. I'll use Mike as an example to explain how connections are supposed to implemented.

Connections should show the connection word + subject, nothing else. So his connections should be:

• winemaker 1973 Chateau Montelena Chardonnay
• mentored by André Tchelistcheff

The dot color should also reflect the linked subject, so in this case, André's dot stays red (person), but 1973 Chateau Montelena Chardonnay's dot should be purple (object).

If we were to then go look at the subject page for one of Mike's connected subjects -- in this case, André, his connection to Mike would read:

• mentored Mike Grgich

The subject order is always selected subject → connection word → connected subject with the selected subject not displayed in the connection text and the connecting word changing form depending on which subject is the selected one. There is a base and reverse form for every connection word.

I'm going to take this explanation a step further to ensure understanding of how this is working from the data side. Let's look at the trello card for André and Mike's connection:

In the trello cards, connections have a specific order and that is how you determine which word to show. The first card is the starting point and uses the first word in the connection label (mentored/mentored by).

Andre → Mike Andre mentored Mike

If you reverse it and read the cards backward, you use the second form on the connection word to connect them.

Andre ← Mike Mike mentored by André

But since the starting subject's card already contains their name and info, we don't need it to repeat in the connections list on the map subject panel and it gets dropped in that context.

[ldragoon]

@qjhart @wrenaria - I think this fix will have to become part of Trello2Moment, because the current JOP data comes over looking like this: