ucd-library / rp-ucd-client

Client application for UCD Davis Library research profiles
MIT License
0 stars 0 forks source link

Empty university author list breaks page #124

Closed jrmerz closed 3 years ago

jrmerz commented 3 years ago

Corner case here, but if no university authors are specified (see isOtherUniversity flag), the query and page breaks here:

https://github.com/ucd-library/rp-ucd-client/blob/3a83ac68a17a54797a3f01ea2797c63a81e0a62b/client/public/elements/pages/work/rp-page-work.js#L156

Followup the isOtherUniversity is a little off, it's just checking for FacultyMember which doesn't include staff. loop could use a little tlc as well:

https://github.com/ucd-library/rp-ucd-client/blob/sandbox/client/public/src/models/WorkModel.js#L182-L198

jrmerz commented 3 years ago

has been fixed here: https://github.com/ucd-library/rp-ucd-client/blob/sandbox/client/public/elements/pages/work/rp-page-work.js#L170