ucd-library / rp-ucd-client

Client application for UCD Davis Library research profiles
MIT License
0 stars 0 forks source link

Edit icons #164

Closed Vensberg closed 3 years ago

Vensberg commented 3 years ago

An edit icon next to the "Positions" field should take users here: https://org.ucdavis.edu/odr/. An edit icon next to "Research areas" field should take users to the Elements section on Fields of Research.

jrmerz commented 3 years ago

@qjhart this issue requires that we have the elements UID. See here: https://github.com/ucd-library/vessel/issues/27. Please let us know if that's possible to add to harvest data.

jrmerz commented 3 years ago

needs to match #75 design

Vensberg commented 3 years ago

Looks good to me. Leaving for @wrenaria to sign off.

wrenaria commented 3 years ago

I have some concerns --

  1. Hover text is needed on both buttons: "Edit Keywords" and "Edit Positions". This will make them consistent with the other editing buttons. Users have also consistently checked for hover text on other editing buttons before clicking on them in user testing. They like the confirmation that it's what they are after.

  2. Looks like the Edit Keywords button goes straight to UC Publication Management without displaying the instructions pop-up. I think the pop-up from issue #75 will be helpful for people to understand what they are supposed to do after they are redirected, so it would be best if we could include that.

  3. After clicking Edit Keywords and signing into UCPM, I get this error: Screen Shot 2021-04-15 at 11 46 45 AM Is this because I am not actually the user I am impersonating, or some other problem? Is it an everyone problem, or a me problem?

jrmerz commented 3 years ago

@wrenaria Issues 1 and 2 above are implemented (deploying now). Issue 3, I'd say there is a 99% chance the impersonating user functionality won't work with that link to elements. I tried the link myself and it worked fine.

wrenaria commented 3 years ago

Not quite there, but almost!

  1. Remove quotation marks in all the editing pop-up titles
  2. People need to know where in UCPM to edit their keywords (as shown in issue #75). I copied the text over and edited it down a little bit based on where the user actually lands on log in to UCPM:

Text for the pop-up:

Edit Keywords
Keywords are managed via the “Fields of Research” section of your UC Publication Management System profile. Clicking the “Edit Keywords” button below will redirect you to the UC Publication Management System. Any changes made there will be reflected on your Aggie Experts profile. 

Steps to Add/Delete Keywords:
1. In the "About" block, select the “Edit” button located just to the right of the “Fields of Research” label.
2. To add keywords, search for and select a subject from “Available values.” To remove keywords, select an item from the “Your Selection” list.
3. Select “Save” to confirm your changes.

And how it should look: Screen Shot 2021-04-16 at 12 06 11 PM

Vensberg commented 3 years ago

I am having the same problem as Kimmy.

Vensberg commented 3 years ago

Also, let's have the window go away once the user is taken to the new tab.

jrmerz commented 3 years ago

@Vensberg which part of Kimmy's discussion are you referring to?

Vensberg commented 3 years ago

The Error once I log into Elements.

jrmerz commented 3 years ago

Are you impersonating someone?

Vensberg commented 3 years ago

No, being myself :)