Closed jrmerz closed 3 years ago
@spelkey-ucd Are you able to replicate this on your phone?
Nope. Looks fine on my iphone 11 on ios 14.4.2.
From: Justin Merz @.> Reply-To: ucd-library/rp-ucd-client @.> Date: Monday, April 19, 2021 at 11:04 AM To: ucd-library/rp-ucd-client @.> Cc: Stephen A Pelkey @.>, Mention @.***> Subject: Re: [ucd-library/rp-ucd-client] Homepage margins breaking on some mobile phones (#199)
@spelkey-ucdhttps://github.com/spelkey-ucd Are you able to replicate this on your phone?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ucd-library/rp-ucd-client/issues/199#issuecomment-822540064, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIFSESXU7PWCXVGHS6CPL73TJRA5XANCNFSM43CGMCNQ.
Unfortunately this is still broken for me (Samsung Galaxy S8). :\
This continues to look the same as pictured in my previous comment on both mine and my partner's phones (both Samsungs -- galaxy s8 and s20).
This is a bug I have not fully tracked down, but as the screenshot shows, the Samsung Chrome phones are bleeding over the padding. This was actually happening on Chrome Pixel phones as well, but only by a couple pixels. It was rendering correctly on the iphone.
The workaround fix required a complete redo of the that panel, so please review carefully to ensure I did not introduce any new bugs.
Needs a bit more spacing under the yellow header/above white body text. Otherwise, looks good on my phone.
This is not showing on every phone, but here is a sample from G8 Samsung.
JM is having trouble replicating. First step will be getting a dev a device that is showing this issue.