ucd-library / rp-ucd-client

Client application for UCD Davis Library research profiles
MIT License
0 stars 0 forks source link

Grants Page Updates #275

Open qjhart opened 3 years ago

qjhart commented 3 years ago

The Grants Information JSON has been updated to include all the roles for the grants, eg for grant:117708, we have the following information below.

We need to to the following on the User Pages

And on the grant page:

The order of the roles as presented should be:

  1. ucdrp:GrantProgramDirectorRole 2.ucdrp:GrantPrincipalInvestigatorRole
  2. ucdrp:GrantCoPrincipalInvestigatorRole
  3. ucdrp:GrantProjectLeaderRole
  4. ucdrp:GrantCoreLeaderRole
  5. ucdrp:GrantKeyPersonnelRole
  6. cdrp:GrantOtherRole

Once we have that in place

"relates": [
{
"@id": "ucdrp:admin_role/049030-117708",
"@type": "vivo:AdminRole",
"label": "MED:Public Health Sciences"
},
{
"@id": "ucdrp:grant/117708#roleda289edb8c350965f6030b690dda9069-KP",
"@type": [
"experts:GrantKeyPersonnelRole",
"vivo:ResearcherRole"
],
"label": "BENNETT, DEBORAH H"
},
{
"@id": "ucdrp:grant/117708#role2018e102d952a54d169bce79abd7ae8c-KP",
"@type": [
"experts:GrantKeyPersonnelRole",
"vivo:ResearcherRole"
],
"inheresIn": {
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c",
"@type": [
"vivo:FacultyMember",
"experts:person",
"foaf:Person"
],
"hasContactInfo": [
{
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c#vcard-oap-1",
"hasName": {
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c#vcard-oap-1-name",
"familyName": "Wexler",
"givenName": "Anthony"
}
],
"label": "Anthony Wexler"
},
"label": "WEXLER, ANTHONY S"
},
{
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c",
"@type": [
"vivo:FacultyMember",
"experts:person",
"foaf:Person"
],
"hasContactInfo": [
{
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c#vcard-odr-1",
"hasName": {
"@id": "ucdrp:person/2018e102d952a54d169bce79abd7ae8c#vcard-name",
"familyName": "Wexler",
"givenName": "Anthony"
}
],
"label": "Anthony Wexler"
},
{
"@id": "ucdrp:pi_role/1875acc4cf6e75cdb379c850a9026f99-117708",
"@type": [
"experts:GrantPrincipalInvestigatorRole",
"vivo:PrincipalInvestigatorRole"
],
"label": "HERTZ-PICCIOTTO, IRVA"
}
],
qjhart commented 3 years ago

@sbagg Added an addtional item to the above

Eg. grant:116272


"assignedBy": [
{
"@id": "ucdrp:funding_org/8614",
"@type": "vivo:FundingOrganization",
"label": "INSTITUTE OF INTERNATIONAL EDUCATION"
},
{
"@id": "ucdrp:funding_org/4293",
"@type": "vivo:FundingOrganization",
"label": "BUREAU OF EDUCATIONAL AND CULTURAL AFFAIRS"
}
],
...
qjhart commented 3 years ago

Some of the formatting questions I have:

Regarding Formatting here are some examples:

Vensberg commented 3 years ago

@sbagg, there seem to be a few grants that are failing to complete rendering. It looks to me, like they are making a call to a non-existent endpoint, and I'm not sure why. Can you look at the two examples below as examples

https://dev.experts.ucdavis.edu/grant/122801 https://dev.experts.ucdavis.edu/grant/111109

qjhart commented 3 years ago

@wrenaria We have updated the grants page with more information, including the administrating organization, and all the researchers involved in a grant. These are added to the dev site, but with outstanding formatting questions. I'm sure you'll see other things, but these are some of the formatting questions I have:

Regarding Formatting for multiple researchers here are some examples:

wrenaria commented 2 years ago

If information is not available (like grant admin), treat like we do everything else on the site: hide it.

For displaying a mix of Aggie Experts collaborators and others, I think we should maintain the heading structure but split contributors into separate sections titled Aggie Experts Contributors and Other Known Contributors, listing the names alphabetically within each section. Here is an example using data from https://dev.experts.ucdavis.edu/grant/117708:

Screen Shot 2021-11-08 at 11 28 21 AM

And from https://dev.experts.ucdavis.edu/grant/15094:

Screen Shot 2021-11-08 at 11 28 08 AM
qjhart commented 2 years ago

This looks fine to me @sbagg / @Vensberg any issues here ? I'm assigning this on to @sbagg