ucd-library / rp-ucd-client

Client application for UCD Davis Library research profiles
MIT License
0 stars 0 forks source link

Update the person page to include overview, teachingSummary and researchInterests #293

Open Vensberg opened 2 years ago

Vensberg commented 2 years ago

A substantial amount of content is on QA, but I don't see anything for Bryan Jenkins, so I am wondering if it is everything or something got lost during transfer. I need to look at the parsley-sage data, but the instance is down.

UcDust commented 2 years ago

Adding the overview, teaching summary, and research interests, to the people page in a new section element. I'm not sure if there are restrictions on the length of those in the oaPolicy site/app, so they may get pretty long.

Also similar to other parts of the page, there would be edit icons for the person to edit their own data, pointing back to http://oapolicy.universityofcalifornia.edu/.

They also blend a bit into 'about', so I'm not sure if @wrenaria prefers them to be in the same section perhaps. @qjhart mentioned we may want to allow markdown text entry in oaPolicy, and then parse and display markdown formatted in RP. if we do something like that, perhaps we should investigate a way to confirm the markdown is valid or something

UcDust commented 2 years ago

We're continuing the markdown parsing in https://github.com/ucd-library/ucdlib-theme/issues/55

UcDust commented 2 years ago

@qjhart has documented some person data in sandbox (as of now) in this spreadsheet.

wrenaria commented 2 years ago

For content organization, I actually want to simplify the headers (using h2) all of the way down the profile page (including for publications and grants), so it goes beyond this specific issue.

Web 1920 – Profile – Websites – 9

I looked through about 20 of the examples in the spreadsheet and they look good. The only ones that bother me are the ones where the "research interests" text is repeated. Is there any way to work around that?

Examples: Xinfan Lin, Shuguang Cui

I also recall the original example shown to me was much, much longer. Will that be a concern moving forward, or is this shorter text more representative of what we expect to have in reality? Substantially longer text may have special UX implications I need to consider.

UcDust commented 2 years ago

Thanks @wrenaria!

I can make the h2 adjustments as you mentioned.

I think we could work around the "research interests" being repeated, perhaps just a check that the text content doesn't contain "research interests" in the first line, and if it does we could hide our heading. But it may look odd if the markdown isn't also an h2. Whatever you prefer though.

It does seem that the shorter text is more representative, most of the samples I've seen are that way.

UcDust commented 2 years ago

Hi @wrenaria, I chatted with @qjhart about parsing out the **research interests: and he brought up that @Vensberg had some people manually create these, and it would be easy enough to remove that in oaPolicy. I've updated the spreadsheet with a new column identifying the 4 individuals in sandbox that have **research in their researchInterests.

UcDust commented 2 years ago

I've also created a pull request to get the latest code merged to sandbox. That should include the latest changes from feedback for the header sizes and text updates.