sorry this one is so long! there was a lot to do to get it in line with the rest of our code. lots of state stuff in react–i don't expect that will be easy to follow reading but i tried to make it as clear as i could. if you could test and see if you find bugs on the /access/list as well as /person/details that would be great
makes access components match the pattern of other assets.
adds details modal for individual access assignments, in same pattern as key serials
makes 'em pretty
removes nested/recursive access state–at most, access.assignments[0].access will be populated, instead of access.assignments[0].access.assignments[]...
when on /access/ (AccessContainer) we will have access with fully populated .assignments (which will not have a nested access)
when on /people/ (AccessAssignmentContainer) we will have assignments[] with a populated .access (which will not have nested assignments)
-when on /people/ (AccessAssignmentContainer, calling access/listAssigned, we only pull the assignments for that person, and pass numberOfAssignments for the list to use
fixes a lot of small bugs, bad handling of state, clarifies names
known weird/less than ideal behavior
when on /person/details, if you assign an access it has an incorrect "number of assignments" value in the table until refresh. this is because in AccessController, we do not pass back the accesses, so assignments.length on the frontend is wrong. could pass back all the assignments (seems unnecessary), could add a property of numberOfAssignments, could just delete the column in the list, or just do nothing about it.- still have some nested state under person details, but intending to fix this next
sorry this one is so long! there was a lot to do to get it in line with the rest of our code. lots of state stuff in react–i don't expect that will be easy to follow reading but i tried to make it as clear as i could. if you could test and see if you find bugs on the /access/list as well as /person/details that would be great
makes access components match the pattern of other assets.
adds details modal for individual access assignments, in same pattern as key serials
makes 'em pretty
removes nested/recursive access state–at most,
access.assignments[0].accesswill be populated, instead ofaccess.assignments[0].access.assignments[]...when on /access/ (
AccessContainer) we will haveaccesswith fully populated.assignments(which will not have a nested access)when on /people/ (
AccessAssignmentContainer) we will haveassignments[]with a populated.access(which will not have nested assignments) -when on /people/ (AccessAssignmentContainer, callingaccess/listAssigned, we only pull the assignments for that person, and passnumberOfAssignmentsfor the list to usefixes a lot of small bugs, bad handling of state, clarifies names
known weird/less than ideal behavior
this is because in AccessController, we do not pass back the accesses, soassignments.lengthon the frontend is wrong. could pass back all the assignments (seems unnecessary), could add a property ofnumberOfAssignments, could just delete the column in the list, or just do nothing about it.- still have some nested state under person details, but intending to fix this next