ucdavis / Peaks

https://getpeaks.ucdavis.edu/
MIT License
7 stars 2 forks source link

Rh/supervisor view #1347

Open laholstege opened 10 months ago

laholstege commented 10 months ago

closes #789 and closes #712

not done yet, but i want opinions on how i'm doing this because i'm not convinced it's the best way. i made a "MyStaff" page accessible through my stuff -> people. or at /Supervisor/MyStaff (guess i could just make it index). on that page is a link to a /Supervisor/StaffStuff/{id} page, where a supervisor can see all the assets/details that would be on a "MyStuff" page

image [adding /MyStuff. link takes you to /Supervisor/MyStaff]

image [what /Supervisor/MyStaff page looks like]

image [what "View" takes you to. /Supervisor/StaffStuff/{id}]

i started to add a report as well, following #712. opened reports index page but started to hate it

i don't really like adding People to MyStuff when most users will not need to see that. i could put it at the bottom (ruining the spelling of PEAKS... EAKSP? lol). could put in another tab but that has the same issue of showing for everyone when most people won't need it. i also don't really like having the Reports tab visible to everyone if it's not going to be useful, but doubt any individual user would care about a report for their assets. there's no role or anything special for being a supervisor, so hard to target in the nav

we do already have a Report/SupervisorDirectReports page, that could be more useful (just lists users like my MyStaff page but links to the react person details) but is behind AnyRole auth image [Report/SupervisorDirectReports]

so, thoughts? this is what reports look like now if you have no permissions. first one links to what i added ☝️ but should this all be report(s)? how should it interact with Report/SupervisorDirectReports? i could combine it so someone without a role can view those reports but only see their own information (i.e. only select themself as a supervisor and only see data for who they supervise) image