search

ucdavis / erplab

ERPLAB Toolbox is a free, open-source Matlab package for analyzing ERP data. It is tightly integrated with EEGLAB Toolbox, extending EEGLAB’s capabilities to provide robust, industrial-strength tools for ERP processing, visualization, and analysis. A graphical user interface makes it easy for beginners to learn, and Matlab scripting provides enormous power for intermediate and advanced users.
http://erpinfo.org/erplab
267 stars 73 forks source link

Pop-ups in loops #104

Closed Allexxann closed 4 years ago

Allexxann commented 5 years ago

pop_epoch2continuous has insuppressable pop-up, which breaks all attempts to loop it in scripts.

Function pop_epoch2continuous has no keys to suppress question box, you have to comment corresponding lines.


Steps to Reproduce

  1. create for-loop with pop_epoch2continuous
  2. get pop-up at the first file to process

Expected behavior: Expected some obvious way of suppressing pop-up, like 'warning' key.

Actual behavior: No such thing.


Versions
OS version [Win10]
Matlab version [2017a]
EEGLAB version [14.1.2]
ERPLAB version [7.0.0]
RenzoLanfranco commented 4 years ago

Hi, I was looking for the same thing.

pop_epoch2continuous.m needs a parameter that allows suppressing the question box. So far, the only solution I've found is changing the erplab M file, which isn't a good one since it prevents from sharing pipelines/scripts.

andrewxstewart commented 4 years ago

Hi there,

Thanks for the report.

I think a call like this should work with no popup and no warning:

EEG2 = pop_epoch2continuous(EEG,'Warning','off');

Does that work for you?

Allexxann commented 4 years ago

Shouldn't that be in the help part of the function? Because it seems like noone here had any idea that's an option at all.

RenzoLanfranco commented 4 years ago
Thanks Stuart. Yes, that solves the issue. -- From: Andrew X StewartSent: 28 April 2020 00:48To: lucklab/erplabCc: Renzo Lanfranco; CommentSubject: Re: [lucklab/erplab] Pop-ups in loops (#104) Hi there,Thanks for the report.I think a call like this should work with no popup and no warning:EEG2 = pop_epoch2continuous(EEG,'Warning','off');Does that work for you?—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe. 
Allexxann commented 4 years ago

Okay, this is solved, the magical parameter is here: pop_epoch2continuous(EEG,'Warning','off');

Shame it's not mentioned in the help part of the function, but whatever.

andrewxstewart commented 4 years ago

I agree that this parameter should already be described in the help for this function.

I have added this now, in the latest commit. This will be included in the next ERPLAB release.

See the changes here: https://github.com/lucklab/erplab/commit/440b0e04e169cb17900c8fe1eb959a1759d194b3