ucdavis / payments

Accept and process credit card payments on campus
MIT License
2 stars 3 forks source link

Make sure inactive accounts are not listed where they shouldn't be used. #398

Open sprucely opened 6 months ago

sprucely commented 6 months ago

For team foundation-plant-services there was a mixup between a couple accounts, one of which is inactive. We should probably go through all the queries hitting FinancialAccounts to make sure we're filtering out inactive ones when appropriate.

jSylvestre commented 5 months ago

@sprucely There is code that catches when in inactive account is used. Was that when happened?

        try
        {
            invoices = await _invoiceService.CreateInvoices(model, team);
        }
        catch (ArgumentException ex)
        {
            ModelState.AddModelError(ex.ParamName, ex.Message);
            return new BadRequestObjectResult(new
            {
                success = false,
                errorMessage = "Errors found in request",
                modelState = ModelState
            });
        }
sprucely commented 5 months ago

I would have to go through the tickets I closed that day, because I have no idea. From the title, I'd assume there is some dropdown or something that allowed a user to select an inactive account.