ucfai / tasks

The administrative bot. Dubbed `autobot` – handles the overall maintenance of each group, each semester.
4 stars 2 forks source link

[Total Automation] CI/CD for `autobot` #37

Open jmuchovej opened 4 years ago

jmuchovej commented 4 years ago

Just a note, when referring to groups... groups := {intelligence, core, data-science, supplementary}

Feature Request, for autobot

Description Whenever new features are added to autobot, run unit-tests to check for code-breaking changes on the incoming PR.

Needs

Flesh out tests/

Initial Comments

Haugf commented 4 years ago

Hey John, we're thinking about adding a tests/ folder under autobot/, can we go over making and testing these unit tests later?

jmuchovej commented 4 years ago

hmm, so... looking at StackOverflow and at py.test... it's kinda, "up to us" to organize the folders. personally, behind the idea of throwing all the tests into a mirrored directory structure that's separate from autobot's source.

so... it would look something like this:

...
autobot
tests  <---
setup.py
...

also, would be useful to get a summary of unittest vs py.test, never used the latter; so i'm unsure, but it seems like it's a better library than unittest.

Haugf commented 4 years ago

pyTest has some self explanatory syntax and it is also the default test package for git actions.

I think this is the better choice

jmuchovej commented 4 years ago

alright, sweet. try to keep track of edits/changes in the conda environment files in envs/?

Haugf commented 4 years ago

Are the conda environment files the linux and macos .yml files?

jmuchovej commented 4 years ago

Are the conda environment files the linux and macos .yml files?

yep! ignore anything else in that folder, for now – i think the "requirements" that show up are for conda explicitly (since you can use pip there, but please do so only as a last resort.)

jmuchovej commented 4 years ago

https://github.com/ucfai/bot/blob/ebfca5e03b9c115b27ffc68b4635efa4f0da73bc/.github/workflows/docker.yml#L1

Building the environment in a Docker container that's released to: