search

ucfinancegroup / pfp

a personal finance app, focused on projections, written in Rust and React
4 stars 0 forks source link

Remove derivative, possibly change equity to stock #220

Closed brettfazio closed 3 years ago

brettfazio commented 3 years ago

people may not know what equity means

brettfazio commented 3 years ago

Going off of this is a loan really a good category to have? Seems confusing from a user's POV

c650 commented 3 years ago

these were taken from plaid we could perhaps alias them i guess

brettfazio commented 3 years ago

I think we can consider aliasing them to make them more accessible terms

c650 commented 3 years ago

What if we had descriptions for them?

c650 commented 3 years ago

ok this issue will now be about changing the names

c650 commented 3 years ago

Going off of this is a loan really a good category to have? Seems confusing from a user's POV

we now use the Loan type... should we remove it or keep it?

                let account_class = match a.account_type.as_str() {
                    "depository" => AssetClass::Cash,
                    "credit" => AssetClass::Loan,
                    "loan" => AssetClass::Loan,
                    "investment" => AssetClass::Equity, // for now classify all investments as broad equities
                    _ => AssetClass::Cash,
                };
brettfazio commented 3 years ago

im not too sure, but what do you think the chance is the user has a loan out to someone else, probably low

c650 commented 3 years ago

im not too sure, but what do you think the chance is the user has a loan out to someone else, probably low

haha is that what it meant? cause i thought it meant the user owes someone else money

c650 commented 3 years ago

i guess going off how we dont consider credit and loans for net worth in snapshot, we may as well exclude it from allocations ?

brettfazio commented 3 years ago

im not really sure, but since we have it as a part of asset class it has to be a positive for the user?

if they do have a 'loan' its likely just a bond (in which case we have a category for that)

c650 commented 3 years ago

then we shall nix it