search

ucfopen / Materia-Widget-Dev-Kit

The Materia Widget Development Kit (MWDK) is a combined development utility and dependency for Materia widgets.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
5 stars 9 forks source link

Docker install option is broken with 2.5.0.0 #75

Closed clpetersonucf closed 3 years ago

clpetersonucf commented 3 years ago

docker inspect <image> is now prepending host_mnt to the Source path of the mounts. This breaks the host directory path MWDK uses to install widgets.

/path/to/materia/fuel/app/tmp/widget_packages

is now

/host_mnt/path/to/materia/fuel/app/tmp/widget_packages
FrenjaminBanklin commented 3 years ago

MWDK is also no longer correctly identifying the Docker container that Materia is running in (as of https://github.com/ucfopen/Materia/releases/tag/v8.0.0) Here: https://github.com/ucfopen/Materia-Widget-Dev-Kit/blob/420f5c0d1ca9c75f10aed9fd6c964b700237fda8/express.js#L468

.*materia-web-base:.* is no longer a thing - can probably simplify this line to

let targetImage = execSync('docker ps -a --format "{{.Image}} {{.Names}}" | grep -e "materia-phpfpm" | head -n 1 | cut -d" " -f2');
iturgeon commented 3 years ago

make sense. I keep messing with the docker stuff and this is the fragile bit

iturgeon commented 3 years ago

I think 'materia-phpfpm' is here to stay ... until we switch to python or something

FrenjaminBanklin commented 3 years ago

For what it's worth, widget installation seems to otherwise work just fine between Materia v8.0.0 and MWDK v2.5.0 once I made the change in the above comment.

FrenjaminBanklin commented 3 years ago

Looks like this is already fixed in #74.

clpetersonucf commented 3 years ago

Fixed in 2.5.1.