search

ucfopen / Materia

Engage students with easily embedded apps for online courses. Supercharge your course with compelling experiences and game mechanics.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
36 stars 34 forks source link

Upgrade to php 8.0.24 and fuelphp 1.9-develop #1407

Closed iturgeon closed 2 years ago

iturgeon commented 2 years ago

PHP support for 7 is ending very soon, so this is an attempt to update to give the team some more runway. PHP 8.0.x doesn't have a very long life either, but this is better than nothing.

Upgrading to PHP 8.0.x required upgrading fuel to a development version unfortunately - there's no official non-dev release that has the updates required to work with PHP 8.0.x

clpetersonucf commented 2 years ago

The changes look good, just need you to update the target branch to dev/9.0.2. Our fork of the fuelphp codesniffer is woefully out of date too, and appears to be choking on now-deprecated curly brace syntax for arrays.

iturgeon commented 2 years ago

@clpetersonucf I re-targeted the desired branch and have a pull request open over at https://github.com/ucfcdl/fuelphp-phpcs/pull/1 to fix the code sniffer so our ci_tests will pass on Materia. It'll require a few steps back and forth to get it working. (first the pr gets merged, then tagged, then the composer.json and .lock file need updates here in Materia)

clpetersonucf commented 2 years ago

ucfcdl/fuelphp-phpcs updated and tagged to v3.0.1.