ucfopen / Materia

Engage students with easily embedded apps for online courses. Supercharge your course with compelling experiences and game mechanics.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
36 stars 33 forks source link

Improved checks to $same_site config value #1433

Closed clpetersonucf closed 1 year ago

clpetersonucf commented 1 year ago

By default, $same_site is null in the core Fuel config, but Fuel later attempts to cast the value to a string, converting null into an empty string. The checks in our overriden cookie class don't catch the empty string value, so sameSame='None' did not get applied correctly. The cookie class will now check for an empty string value and update $same_site to 'None' manually.