Open clpetersonucf opened 1 year ago
-cores
aren't loading properly, which is expected. NGINX dev was providing a redirect, but the easier thing is to probably scrap putting compiled assets in public/dist
and just emit them straight into the public
directory, to better match where those assets were located before.~Materia-Theme-UCF
are not rendering yet (note: this is resolved, but the resolution is in the private UCF docker-compose that's not within ucfopen.)width: 100vw;
rule combined with a hidden image that's over 1000 pixels wide.The creator Save History dialog's cancel button is operable
The widget icon alignment in the detail page is skewed
The "Return to My Widgets" link in the creator header, when editing a widget, is constructing a malformed URL
New issues discovered in the apha4 build:
draft_not_playable
page not rendering properlyResolved @cayb0rg's feedback items:
Searching by creation date/time doesn’t work in the admin/support pages
There wasn't a good way to implement this, so the language suggesting this as an option has been updated.
(Missing feature) Cannot see the owner of a widget in admin/support pages (could have been omitted for privacy?)
Instance owners are now displayed in instance admin. Also added instance IDs and user IDs as URL hashes for each admin page, allowing direct navigation to a user or instance management if you know their ID.
Help/Support contact details missing
This requires enabling an additional environment variable, which is disabled by default. However, some locations where support information should be displayed may not display the overridden support details yet.
Widget navigation in My Widgets disappears on smaller screen widths (<980px):
The media query that causes this has been removed, pending a better implementation of responsiveness on the My Widgets page.
Style improvements:
Collaborator Issues
The score screen is making a call to apiGetWidgetInstanceScores
when in the context of reviewing another user's score from My Widgets, which is a behavior not present on production. This causes the score screen to error out in some situations due to permission mismatches, such as when the user has View Scores access to the widget.
Not an issue, but having the option to see the created_at date and possibly sort by or search for date in My Widgets could be useful, since we're already sorting by that value.
The widget catalog does not appear to filter widgets by the in_catalog
flag.
What I've noticed thus far:
@dmols some more specificity is useful here:
Might be best to leave it as is though, since even the landing page for the Fold doesn't have correct display.
What model of Fold? The cover screen or interior screen? Knowing those it's at least possible to emulate the display size using dev tools to identify styling issues.
MyWidgets also doesn't display correctly
How so?
refetchInstances
in select-item.jsx
is not a functionhttps://localhost/lti/assignment?widget=[id]
) do not load in LTI Assignment Launch, dunno if these are necessary or still work in some cases@clpetersonucf , here are some extra details on my review!
What model of Fold? The cover screen or interior screen? Knowing those it's at least possible to emulate the display size using dev tools to identify styling issues.
This I'm not entirely sure about since I haven't been able to test every model, but I assume the screen size is the same for every model, since users online have mentioned having issues with any and all. Also the dev tools for Google Chrome only indicate one option for the 'Fold'.
MyWidgets also doesn't display correctly
Apologies for not elaborating fully; the page displays but it's extremely zoomed in, despite what device it's displayed on, even the standard 'responsive' option. The full page does not fully show when using the dev tools, and minimizing the window down to a certain range (wish I knew how to grab the exact pixel width but inspecting seems to make the issue worse) cuts off the right edge of the content.
The footer can become visually decoupled from the widget player when the embedded iframe scales responsively (this was embedded as an assignment in Webcourses):
Hash changes while on the My Widgets Page do not redirect to that widget (such as when you click on a link in a notification)
No error given when attempting to add a student with only the support_user role (no basic_author role) when guest mode is disabled. It doesn't save (as expected), but it also doesn't raise any errors.
Last name overlaps role in Collaborator:
Making a copy of a widget in Instance Admin sets the hash to an object
@cayb0rg just a heads up I have fixes for 1 and 4 in https://github.com/ucfopen/Materia/pull/1492
in_catalog
determines whether a widget is featured, is_playable
determines whether a widget will be displayed in the catalog at all.drawScoreCircle()
. This is likely due to a race condition.More for quality of life, but it could be helpful to prefill the course ID in the extra attempts dialog with the current selected instance's ID since we're already passing in inst
.
play_logs_save
returns a score url in addition to the score, in addition to an overlap in timing for when logs are submitted. I'm working on untangling this code a bit and implementing a fix.)~IS_EMBEDDED
is provided as a window valuebeforeunload
should not be displayed in situations where the player has errored out (such as an invalid heartbeat)
Figured it'd be easier to create a single issue for people to submit feedback based on testing Materia v10 on QA. I can stub out issues based on items people submit.