Issue-1469/notifications

[cayb0rg]

Starts the notification UI for #1469

[cayb0rg]

Thanks for the feedback!

New changes:

• “Grant access” now redirects user to my widgets and adds the requesting user in collaborator
• Notification shows error message on server failure
• Adds sent timestamp to notifications
• Fixes request access success message showing for all owners in LTI view
• Fixes widget link href in notifications
• Sender avatar is no longer clickable
• Changes delete button to an SVG
• Clicking outside notifications closes notifications
• Notification symbol no longer persists after notifications have all been dismissed

[cayb0rg]

It does make more sense to perform the update after the player hits save. I've changed it to update the query data instead, but this may need further testing.

Edit: Not functioning correctly upon further testing. Cancelling and attempting to grant access to another user doesn't add them to the collaborator.

Edit 2: Reverted to the previous method.

[clpetersonucf]

A follow-up to my last comment: the issues relating to duplicate collaborators is related to loose management of variable types, particularly with user perms.

In the my-widgets-page component, we're explicitly setting the user ID key of the other user perms' object to an int: https://github.com/ucfopen/Materia/blob/0d139fafcecf8931b59f7d0da2c42ea118088004/src/components/my-widgets-page.jsx#L128

However, in the support-selected-instance component, that same value is not being explicitly set. It ends up being cast as a string, which is something that (iirc) changed with the PHP 8.1 update. That causes comparisons downstream to fail, like this one, which is why collaborators end up duplicated in one version of the collaborator dialog but not another: https://github.com/cayb0rg/Materia/blob/69f311cd0e1ea44381f9575bc1cbd6d4252f5c6a/src/components/my-widgets-collaborate-dialog.jsx#L250

I would wrap the user perm key in a parseInt() in the support-selected-instance component as well, because IMO, ints are preferable to strings for these numeric IDs. That also means I'd probably remove this line: https://github.com/cayb0rg/Materia/blob/69f311cd0e1ea44381f9575bc1cbd6d4252f5c6a/src/components/my-widgets-collaborate-dialog.jsx#LL83C3-L83C3 Since it's trying to perform the opposite. Unfortunately, the looseness of type definitions in javascript is biting us here a little bit 😬

[cayb0rg]

New changes:

• Deletes notifications optimistically (instead of calling notification_get every time a notification is deleted)
• Support users can be added as collaborators even if they are students
• Adds null check for newCollabUser
• Fixes an issue with added users not appearing in collaborator
• Disabled option to remove yourself as a collaborator if you have view access (quick fix to this issue)
• Adds parseInt() to support selected instance to fix duplicated users