search

ucfopen / Materia

Engage students with easily embedded apps for online courses. Supercharge your course with compelling experiences and game mechanics.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
36 stars 33 forks source link

Fix widget footer margins #1490

Closed cayb0rg closed 1 year ago

cayb0rg commented 1 year ago

Prevents widget footer from centering itself in the page.

clpetersonucf commented 1 year ago

This works, but I'd actually prefer to add margin: 0 auto; to the section.widget .center selector in the same file. Currently, the fix causes the player to left-align to the available space, while the alternative would center-align the player and footer together (but we should still test the player in various embed environments to make sure it displays properly).

cayb0rg commented 1 year ago

True. I considered that as well and thought being left-aligned looked more congruent with WebCourses, especially on wide screen sizes. If the author wanted to center one embedded in a page, they could use WebCourses' text centering option (or add style = "text-align: center;" if it's outside WebCourses). However, I'm totally open to making it centered by default since this centering option is not available for LTI embedded widgets, and there are ways of making it left-aligned again in pages if they wanted it to be.

Centering also does look better when opened in new tab.