ucfopen / Materia

Engage students with easily embedded apps for online courses. Supercharge your course with compelling experiences and game mechanics.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
36 stars 33 forks source link

[React branch] Fixes and polish part five #1492

Closed clpetersonucf closed 11 months ago

clpetersonucf commented 1 year ago

Bug fixes:

Improvements:

clpetersonucf commented 12 months ago

Ready for review.

clpetersonucf commented 12 months ago

missing Preview/Play again button

@cayb0rg I can't believe I overlooked the missing Preview Again button, but do you have examples of when the Play Again button should be present and isn't?

cayb0rg commented 12 months ago

Play Again is missing when a widget is set to Guest Mode, because attemptsLeft is never set the second time (the first time, instance hasn't loaded yet). In Normal mode, attemptsLeft gets set after the instance scores are loaded.

Adding instance as a dependency to the useEffect for attemptsLeft I think should fix it.

FrenjaminBanklin commented 12 months ago

The only other things I see are incredibly minor.

clpetersonucf commented 12 months ago
clpetersonucf commented 12 months ago