Even though settings are correctly saved to the server and subsequent pulls from the API include the correct data, the local query cache containing the instance list wasn't being updated because the function that converts the raw query data into the actual instance list is memoized for performance. The useMemo hook only does a shallow comparison of objects and would not register the changes applied to an individual instance.
Instead, this PR adds a modified value to the local query cache when it is altered locally via setQueryData - for example, updating, copying, or deleting an instance. This is recognized by the useMemo hook which refreshes the instance list appropriately.
Additionally, the useUpdateWidget hook was stringifying certain values that should be integers - as far as I can tell there's no need for them to be strings, when the values from the server are always ints. They've been updated accordingly.
Resolves #1553
Even though settings are correctly saved to the server and subsequent pulls from the API include the correct data, the local query cache containing the instance list wasn't being updated because the function that converts the raw query data into the actual instance list is memoized for performance. The
useMemo
hook only does a shallow comparison of objects and would not register the changes applied to an individual instance.Instead, this PR adds a
modified
value to the local query cache when it is altered locally viasetQueryData
- for example, updating, copying, or deleting an instance. This is recognized by theuseMemo
hook which refreshes the instance list appropriately.Additionally, the
useUpdateWidget
hook was stringifying certain values that should be integers - as far as I can tell there's no need for them to be strings, when the values from the server are always ints. They've been updated accordingly.