search

ucfopen / Materia

Engage students with easily embedded apps for online courses. Supercharge your course with compelling experiences and game mechanics.
https://ucfopen.github.io/Materia-Docs/
GNU Affero General Public License v3.0
36 stars 34 forks source link

Make DevMateria's Grunt tasks compatible for Babel & React #714

Closed WilliamRADFunk closed 8 years ago

WilliamRADFunk commented 8 years ago

This issue was created for the more immediate issue that the Dodgeball widget can't transfer to Materia without the Grunt being updated for what its Gulp counterpart is currently doing for jsx transformation.

This is a temporary fix. Later, grunt will be phased out for all-Gulp setup.

zachberry commented 8 years ago

Which issue / branch / pull request can I look at to QA this?

WilliamRADFunk commented 8 years ago

The gulp-build branch in devMateria should be the one you need. I also had to use the direct <grunt package --widget=Dodgeball> command to package the widget (this is where grunt does its new thing).

I then, from Materia side (since I'm using docker now), do this: <cp /Users/wfunk/Desktop/devmateria/sandbox/Dodgeball/_output/Dodgeball.wigt app/fuel/app/tmp> from the main folder (materia-docker for me) Note: you may have to create the tmp folder yourself.

Then <./install_widget.sh Dodgeball.wigt> in same folder

Then I switch to the app folder one level down and: <docker-compose run phpfpm php oil r widget:create_instance -i>

Enter in the following order: ~author y --- (confirms ~author as owner) the number where Dodgeball is installed in your folder (mine is 16) Bob's Widget --- Name your widget instance y --- (asks if you want stub qset) n --- (display it?) n --- (Change owners?) Then you're good to go.

Didn't realize until now how many steps this takes, but it is for a stand-alone widget instance for only one teacher. Shouldn't be a lot of repetition when it's done.

WilliamRADFunk commented 8 years ago

Try to use the all-things-dodgeball branch as it is the most up-to-date version of the widget.

zachberry commented 8 years ago

QAed. Tested viewing, installing, previewing and playing both Labeling (a non-react widget) and Dodgeball (react, babel). Both worked great.

However I saw a few code issues. I made a pull request on clu to easily see changes and left comments there: https://clu.cdl.ucf.edu/materia/devmateria/merge_requests/2

zachberry commented 8 years ago

QAing

zachberry commented 8 years ago

LGTM

clpetersonucf commented 8 years ago

These changes appear to have been merged in via the big-gulp branch in DevMateria, archiving