Proof Reading Symbols

[SMason2057]

The Proof Reading Symbols widget needs to be reviewed to see if there are any bugs or errors.

[FrenjaminBanklin]

Technically the only thing that seems strange is that finishing the widget produces a message on the screen reading 'Cannot POST /sandbox/.compiled/proof-reading-symbols/test_mail_basic.php'. This may be expected in devmateria? If not, suppose that's an error.

Additional critique: Name entry as a requirement for proceeding to the first question seems unclear, and/or the widget could benefit from instructions in general. Clickable areas aren't immediately evident, as they only change the cursor when hovered over.

Also, the widget seems mostly to still be contained in a .swf file.

[zachberry]

Regarding the .swf file - for these widgets we're not doing any reimplementing, simply wrapping them inside a "Materia shell". So that should be OK.

[clpetersonucf]

Putting this back into the Backlog, to be turned into a Real Widget™ in the near future (post-AWS push)

[clpetersonucf]

Shauna has been working on making this a Real Widget™. Updates are ready for QA - on branch proof-reading-symbols-htmlVersion

[FrenjaminBanklin]

The last commit on that branch is from March. Is widget/proof-reading-symbols the working branch?

[clpetersonucf]

@FrenjaminBanklin whups, you're totally right

[WilliamRADFunk]

QAing

[FrenjaminBanklin]

QA'd. Comments left on merge request in widget repo at https://clu.cdl.ucf.edu/materia/proof-reading-symbols/merge_requests/1.

Seems to be working, but needs a lot of cleanup.

[WilliamRADFunk]

QA'd.

First note: widget doesn't seem to install to Materia. I used a fresh devmateria clone to package the .wigt file and download it (it does). When installing to Materia through the command line it only "Extracts", but does not install the widget. Further inspection of the log file tells me that the score module is missing.

There is no creator for this to test, but I'm to understand that that is not required for this widget.

In Devmateria, the widget performs as I imagine it should. It gives the right answer after the student guesses wrong twice. Don't know if that is the intent, but it is consistent.

It could benefit from a little polish on the color/style appearance.

Though it seems silly because it already says click on the mark etc., but it may help to add additional explanation that they are to click on the text document itself. Since it looks kind of like a scanned pdf with handwritten changes, it may not be intuitive that the "hand-written" stuff is clickable.

Minor additions to instructions, maybe a modal with a graphic as demo at the beginning.

Is there supposed to be a "try again" option after the first run of the widget? Is the scoring shown at the end supposed to be in addition to Materia's normal scoring methods, or as a replacement for it. The latter possibility may be the reason there was no score_module during installation into Materia. I'm fairly certain, one way or another, that a score module must be included.

In some symbols, it is hard to see them when glancing over the document. The strike-through on "very" as an example. Would it be bad to highlight the clickable zones in some subtle way? Just thinking out loud.

Looks good. Should be a good addition to the collection.

[SMason2057]

Updated proof reading symbols. Added in creator files, an instruction modal, and made clickable areas stand out from the rest of the text.

[FrenjaminBanklin]

Gave it another look. It doesn't seem like reaching the 'final score' screen actually sends scores and ends the widget.

I still see a lot of files that aren't used and extraneous white space.

Also, it looks like there are 11 clickable areas - and in the player's code, space for 11 questions. Was this widget supposed to have 11 questions? If so, why does it stop at 10?

[SMason2057]

In the original, there were 11 clickable areas, but only 10 questions were asked.

[SMason2057]

Updated widget. Scoring now works.

[clpetersonucf]

This needs to be ready prior to Fall start. Requesting QA happens asap.

[FrenjaminBanklin]

Works fine in DevMateria, installs properly, but trying to play in Materia produces this error upon clicking an answer:

angular.js:9778 TypeError: Cannot read property 'id' of undefined at h.e.checkAns (player.js:1) at angular.js:10567 at angular.js:18627 at h.$eval (angular.js:12412) at h.$apply (angular.js:12510) at HTMLImageElement. (angular.js:18626) at HTMLImageElement.dispatch (jquery.min.js:3) at HTMLImageElement.v.handle (jquery.min.js:3)

[SMason2057]

Looks like I didn't push the updated .wigt file to clu. Tested it in Materia. It should work now.

[SMason2057]

Updated Proof Reading Symbols to fix 'cannot read property id of undefined' error when clicking on an answer.

[FrenjaminBanklin]

Widget installs properly and seems to be playing/scoring correctly.

Only things left to do that I can see:

• Currently there are two screenshot directories; _screen-shots and _screen-shots, with a space at the end of the name which contains the correct assets. Make sure there's only one directory and that there aren't spaces at the end of its name.
• The 788-pixel image in the icons folder is the 'Hello Widget' icon, but it should be the gear icon like the rest.
• The list of questions in both creator.coffee and player.coffee is malformed; there's no comma between the 10th item and the 11th item. In addition to this, if the 11th question isn't being used then it's safe to remove it entirely.
• player.html could stand to be cleaned up a lot. Try to give each tag/text block its own line, within reason. Opening tags with a lot of attributes should be split up such that each attribute is given its own line for the sake of readability.
• Proof Reading Symbols probably shouldn't show up in the catalog by default. Set in_catalog to 'No' in install.yaml.

[SMason2057]

Fixed issues from previous feedback. Should be good to go.

[FrenjaminBanklin]

Did a tiny bit of cleanup, otherwise it looks ready to me.

[FrenjaminBanklin]

One last thing: The creator uses the UCF Psychology logo. Unless this is actually one of those, it should probably have a regular UCF logo minus the word 'Psychology'. Or no logo at all, like the Static Preposition Locator or Be Finder creators.

[clpetersonucf]

Looks great, but one last thing: The text characters embedded(?) in the SVGs are not displaying properly on some browsers (notably - Edge and IE. Because of course.)

Is there a better way of embedding those text characters in the SVGs? We could convert them to paths, instead of characters.

[clpetersonucf]

Shauna updated the SVGs with PNGs. Testing in all browsers. Looks great. LGTM.