search

ucfopen / UDOIT

The Universal Design Online content Inspection Tool, or UDOIT (pronounced, “You Do It”) enables faculty to identify accessibility issues in their Learning Management System. It will scan a course, generate a report, and provide resources on how to address common accessibility issues.
GNU General Public License v3.0
108 stars 65 forks source link

Add suggestion for when iframe content is detected #290

Open bagofarms opened 7 years ago

bagofarms commented 7 years ago

For any iframe content that is not detected by #289 , throw a suggestion with

Title: External content may be inaccessible.

Description: Embedded content is not evaluated automatically by UDOIT. Please manually evaluate this content for accessibility issues and compatibility with mobile devices.

bagofarms commented 3 years ago

I think this feature request is still valid for UDOIT 3.x

mrash2 commented 2 years ago

What exactly should happen in UDOIT when an iframe is detected? Our install returns a rule.label.IframeNotHandled error on these, but clicking on the error gives mixed results. In some cases it opens the preview in the dialog modal as expected, other times it throws a "refused to connect" error when reviewing these errors. I realize UDOIT is not intended to scan the iframe, but I'm not sure what the user should expect to see nor how the user is expected to respond to these. Thanks!

bagofarms commented 2 years ago

The functionality in 3.2.0 (still in development) is that it displays a message stating that it cannot scan iFrame content and attempts to load the iFrame for review. It's possible your browser is blocking the page. Could you post a screenshot of the issue you're seeing?

mrash2 commented 2 years ago

Thanks. Here are a few screenshots.

First the list of iframe errors, which just show rule.label.IframeNotHandled: image

Upon selecting the first error in the above list, here's the normal popup, mostly as expected: image

Upon selecting the second error in the above list, here's the popup. Note that the iframes on the page titled Module 1 are all Canvas Studio videos embedded using the LTI in the rich content editor. Perhaps Studio refuses to be an iframe within an iframe when the UDOIT dialog attempts to load it? Either way, it leaves the user wondering what just happened. :-) image

mrash2 commented 2 years ago

Update: we have updated our install to 3.2 and the iframe handling is much better. However, I will add that, if the iframe in question is an embedded Canvas Studio video, and the Preview (default) option is selected in the issue viewer modal in UDOIT, the iframe refusal to display takes over the modal. The buttons at the bottom work, but there's no option to link to the page in question, switch to HTML, or manually mark as resolved. The only option is to close the modal or navigate to an issue that doesn't have this problem, switch to HTML view, and navigate back to the issue in question. The user experience looks just like my last screenshot in the comment above. The other two screenshots were resolved by upgrading to 3.2.