search

ucfopen / canvasapi

Python API wrapper for Instructure's Canvas LMS. Easily manage courses, users, gradebooks, and more.
https://pypi.python.org/pypi/canvasapi
MIT License
561 stars 175 forks source link

Update `PaginatedList` #614

Closed bennettscience closed 1 year ago

bennettscience commented 1 year ago

Based on #605, PaginatedList could not process requests which return pagination info in the response body. This update checks for Link headers before checking the meta property in the response body.

Resolves #605 Related: #565

codecov[bot] commented 1 year ago

Codecov Report

Merging #614 (7cf4936) into develop (ac2fc96) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         3684      3691    +7     
=========================================
+ Hits          3684      3691    +7
Impacted Files Coverage Δ
canvasapi/paginated_list.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bennettscience commented 1 year ago

I've made the changes requested, all tests passing still.