search

ucfopen / canvasapi

Python API wrapper for Instructure's Canvas LMS. Easily manage courses, users, gradebooks, and more.
https://pypi.python.org/pypi/canvasapi
MIT License
554 stars 173 forks source link

Course Create Discussion Attach Files #621 #622

Closed Thetwam closed 1 year ago

Thetwam commented 1 year ago

Fix issue where Course.create_discussion_topic doesn't accept attachment files

Fixes #621

codecov[bot] commented 1 year ago

Codecov Report

Merging #622 (e533efc) into develop (44c61ca) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #622   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         3726      3732    +6     
=========================================
+ Hits          3726      3732    +6
Impacted Files Coverage Δ
canvasapi/course.py 100.00% <100.00%> (ø)
canvasapi/requester.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thetwam commented 1 year ago

Do tests need to be updated to check cases where the file isn't valid?

Good call, updated.