search

ucfopen / labeling-materia-widget

Materia widget where students select items and use them to label parts of an image.
GNU Affero General Public License v3.0
1 stars 4 forks source link

added creator and player guides #8

Closed weining-li closed 5 years ago

weining-li commented 5 years ago

:octocat:

clpetersonucf commented 5 years ago

We've refined how helper-docs are added to widgets and the requisite webpack configurations. Here's a gist highlighting the current requirements: https://gist.github.com/clpetersonucf/261a8b7a2d89c6c9304ece6b52cfc1b7

You can also review the diff for Crossword to show how Crossword is adding the helper-docs: https://github.com/ucfopen/crossword-materia-widget/pull/12/files

It'll be necessary to make some changes to this PR to support the helper-docs configs, but generally speaking it just involves simplifying some things.

weining-li commented 5 years ago

Travis CI is giving me error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "12.6.0"

Manually changing the upath "^1.0.0" to upath "^1.1.1" in yarn.lock seems to be solving the issue. Is this safe to do?

FrenjaminBanklin commented 5 years ago

It would probably be better to find the dependency we're using that eventually depends on the outdated version of upath and update that instead, then make sure everything still works etc.

yarn why may be of some help to you there.

clpetersonucf commented 5 years ago

Travis CI is giving me error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "12.6.0"

Manually changing the upath "^1.0.0" to upath "^1.1.1" in yarn.lock seems to be solving the issue. Is this safe to do?

I ran into that too, and the only other workaround is to add the --ignore-engines flag when running yarn install. If that fixes the problem and yarn install/yarn build work after doing so, that's OK by me.