search

ucgmsim / Ancillary-tools

Ancillary tools to create data used in GM Sim workflow
0 stars 0 forks source link

Ancillary-tools --> Ancillary_tools #1

Open sungeunbae opened 3 years ago

sungeunbae commented 3 years ago

The name of this repo uses "-" while its name uses "_" when imported.

CPT_Vsz_Vs30/computeVsz.py:from Ancillary_tools.CPT_Vsz_Vs30.calculations import compute_vsz_from_vs
CPT_Vsz_Vs30/computeVs30.py:from Ancillary_tools.CPT_Vsz_Vs30.calculations import vsz_to_vs30, vsz_to_vs30_sigma
SPT_Vsz/Vs2Vs30.py:from Ancillary_tools.CPT_Vsz_Vs30 import calculations

I'd like to propose we stick to "_"

jasonmotha commented 3 years ago

The repo wasn't intended to be a module. I think we'd be better off as part of the structured change to make some of this functionality into a module. Regardless, we can make the change but importing this repo like that was unintended.